On Fri, Sep 18, 2026 at 10:53 AM Richard Biener <[email protected]> wrote: > > On Wed, Sep 16, 2026 at 5:11 AM Léo Hardt <[email protected]> wrote: > > > > Good evening, > > > > This is a trivial patch containing only either removals of include > > directives or their substitution by more specific alternatives. > > No behaviour was changed. > > > > Notice that tree-pretty-print.h only includes pretty-print.h and > > declares functions. Therefore, including pretty-print.h directly > > is more succinct when only pretty-print's declarations are needed. > > > > This is a follow-up to: > > https://gcc.gnu.org/pipermail/gcc-patches/2026-September/731230.html > > > > Successfully bootstrapped on my Intel machine. > > So I have the same issue as with the previous patch: > > > b4 am [email protected] > Looking up > https://inbox.sourceware.org/gcc-patches/[email protected]/ > Grabbing thread from > inbox.sourceware.org/gcc-patches/[email protected]/t.mbox.gz > Analyzing 1 messages in the thread > Looking for additional code-review trailers on lore.kernel.org > Nothing matching that query. > Checking attestation on all messages, may take a moment... > --- > ✓ [PATCH] clean(imports): Remove Unused Includes and Downgrade Others > --- > ✓ Signed: DKIM/inf.ufrgs.br > --- > Total patches: 1 > --- > Link: > https://inbox.sourceware.org/gcc-patches/[email protected] > git am > ./20260916_leom_hardt_clean_imports_remove_unused_includes_and_downgrade_others.mbx > > git am > > ./20260916_leom_hardt_clean_imports_remove_unused_includes_and_downgrade_others.mbx > Applying: clean(imports): Remove Unused Includes and Downgrade Others > error: git diff header lacks filename information when removing 1 > leading pathname component (line 24) > Patch failed at 0001 clean(imports): Remove Unused Includes and Downgrade > Others > hint: Use 'git am --show-current-patch=diff' to see the failed patch > hint: When you have resolved this problem, run "git am --continue". > hint: If you prefer to skip this patch, run "git am --skip" instead. > hint: To restore the original branch and stop patching, run "git am --abort". > hint: Disable this message with "git config set advice.mergeConflict false" > > so can you re-send it as attachment and possibly review the way you are > sending > patches?
Received privately and pushed. Richard. > > Thanks, > Richard. > > > gcc/ChangeLog: > > > > * asan.cc: Remove include that already came from ssa.h. > > * gimple-ssa-pta-constraints.cc: Remove unused include. > > * tree-ssa-loop-unswitch.cc: Likewise. > > * ubsan.cc: Change an include to a more specific file. > > * value-query.cc: Remove unused import. > > * value-range-storage.cc: Likewise. > > * value-range.cc: Change an include to a more specific file. > > > > Signed-off-by: Léo Hardt <[email protected]> > > --- > > gcc/asan.cc | 1 - > > gcc/gimple-ssa-pta-constraints.cc | 1 - > > gcc/tree-ssa-loop-unswitch.cc | 1 - > > gcc/ubsan.cc | 2 +- > > gcc/value-query.cc | 1 - > > gcc/value-range-storage.cc | 1 - > > gcc/value-range.cc | 2 +- > > 7 files changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/gcc/asan.cc b/gcc/asan.cc > > index 7f625fdcfa0..9d9de84ed52 100644 > > --- a/gcc/asan.cc > > +++ b/gcc/asan.cc > > @@ -34,7 +34,6 @@ along with GCC; see the file COPYING3. If not see > > #include "tm_p.h" > > #include "ssa.h" > > #include "stringpool.h" > > -#include "tree-ssanames.h" > > #include "optabs.h" > > #include "emit-rtl.h" > > #include "cgraph.h" > > diff --git a/gcc/gimple-ssa-pta-constraints.cc > > b/gcc/gimple-ssa-pta-constraints.cc > > index b433aee8243..fe8bd738f33 100644 > > --- a/gcc/gimple-ssa-pta-constraints.cc > > +++ b/gcc/gimple-ssa-pta-constraints.cc > > @@ -29,7 +29,6 @@ > > #include "tree-pass.h" > > #include "ssa.h" > > #include "cgraph.h" > > -#include "tree-pretty-print.h" > > #include "diagnostic-core.h" > > #include "fold-const.h" > > #include "stor-layout.h" > > diff --git a/gcc/tree-ssa-loop-unswitch.cc b/gcc/tree-ssa-loop-unswitch.cc > > index e1650c1f9ae..0f600a3701f 100644 > > --- a/gcc/tree-ssa-loop-unswitch.cc > > +++ b/gcc/tree-ssa-loop-unswitch.cc > > @@ -37,7 +37,6 @@ along with GCC; see the file COPYING3. If not see > > #include "cfghooks.h" > > #include "tree-ssa-loop-manip.h" > > #include "tree-vectorizer.h" > > -#include "tree-pretty-print.h" > > #include "gimple-range.h" > > #include "dbgcnt.h" > > #include "cfganal.h" > > diff --git a/gcc/ubsan.cc b/gcc/ubsan.cc > > index 79a863b46ce..fb5ddc02670 100644 > > --- a/gcc/ubsan.cc > > +++ b/gcc/ubsan.cc > > @@ -31,7 +31,7 @@ along with GCC; see the file COPYING3. If not see > > #include "tm_p.h" > > #include "ssa.h" > > #include "cgraph.h" > > -#include "tree-pretty-print.h" > > +#include "pretty-print.h" > > #include "stor-layout.h" > > #include "cfganal.h" > > #include "gimple-iterator.h" > > diff --git a/gcc/value-query.cc b/gcc/value-query.cc > > index 337f66d9a79..78976e21f25 100644 > > --- a/gcc/value-query.cc > > +++ b/gcc/value-query.cc > > @@ -26,7 +26,6 @@ along with GCC; see the file COPYING3. If not see > > #include "tree.h" > > #include "gimple.h" > > #include "ssa.h" > > -#include "tree-pretty-print.h" > > #include "tree-ssanames.h" > > #include "fold-const.h" > > #include "value-query.h" > > diff --git a/gcc/value-range-storage.cc b/gcc/value-range-storage.cc > > index 14fa6e29a9f..08c85a8880b 100644 > > --- a/gcc/value-range-storage.cc > > +++ b/gcc/value-range-storage.cc > > @@ -26,7 +26,6 @@ along with GCC; see the file COPYING3. If not see > > #include "gimple.h" > > #include "gimplify.h" > > #include "ssa.h" > > -#include "tree-pretty-print.h" > > #include "fold-const.h" > > #include "gimple-range.h" > > #include "value-range-storage.h" > > diff --git a/gcc/value-range.cc b/gcc/value-range.cc > > index 8c0d418f614..6fb1e801f2b 100644 > > --- a/gcc/value-range.cc > > +++ b/gcc/value-range.cc > > @@ -26,7 +26,7 @@ along with GCC; see the file COPYING3. If not see > > #include "tree.h" > > #include "gimple.h" > > #include "ssa.h" > > -#include "tree-pretty-print.h" > > +#include "pretty-print.h" > > #include "value-range-pretty-print.h" > > #include "value-range-storage.h" > > #include "fold-const.h" > > -- > > 2.47.3 > > > >
