Drea Pinski (pinskia) <[email protected]>) commented on the code:

> +++ gcc/testsuite/g++.dg/tree-ssa/ssa-dse-1.C
> @@ -5,1 +5,4 @@
>  
> +// Use a byte-sized enum so the initializer remains a CONSTRUCTOR rather than
> +// becoming a STRING_CST, preserving the stores this test exercises.
> +enum class byte : unsigned char {};
> Use byte-sized
enum elements in the DSE test to preserve its original optimization check,
and add a regression covering sparse and dense aggregates and their
runtime contents.

I think we want to keep both versions of the testcase. More to the point both 
versions should be optimized.

Can you show how dse1 output differs with/without the patch? And maybe we need 
to change the scan and add a new version of the testcase. 


--
https://forge.sourceware.org/gcc/gcc/pulls/237#issuecomment-7651

Reply via email to