> > > > The wrappers seem overkill. > > > >> +/* Bit layout matches Linux `PERF_SAMPLE_*` > >> (include/uapi/linux/perf_event.h). > >> + perf.data attrs.sample_type uses these values. */ > > > > Why not just use the standard linux include? > Do you suggest that we use the linux headers directly making it a dependency? > Or do you want to copy headers or part of the headers directly? > I am not sure if we need to consider any licensing issues if we are copying > the headers here.
I would just include the headers and use them instead of trying to re-create the data structures that much. -Andi
