Hi, On Tue, Sep 29 2026, Léo Hardt wrote: > Good evening, > > This is a trivial patch that follows r17-4362-g49501df9860312. > > Removed instances in which header files were included twice with no > effect. Checked that the included header files have include-guards > and that the includes weren't in different '#if' blocks. The first > inclusion was preserved. > > This usually happens when a file must be included, and so the patch > author just adds the required header plus all their dependencies, > without thoroughly checking whether each file was already included. > > You can check the validity of this commit by running on ./gcc: > > find . -maxdepth 2 -type f -name "*.cc" \ > | xargs grep '#include "stor-layout.h"' \ > | sort \ > | uniq -d > > And similarly for other includes by replacing "stor-layout.h" above. > > Bootstrapped successfully on my Intel machine. > > Signed-off-by: Léo Hardt <[email protected]> > > gcc/ChangeLog: > > * caller-save.cc: Remove unused include directives > * cse.cc: Likewise. > * dwarf2ctf.cc: Likewise. > * function-tests.cc: Likewise. > * gimple-pretty-print.cc: Likewise. > * gimple-range-trace.cc: Likewise. > * gimple-range.cc: Likewise. > * gimple-ssa-store-merging.cc: Likewise. > * ipa-devirt.cc: Likewise. > * ipa-inline-transform.cc: Likewise.
The ipa-devirt.cc and ipa-inline-transform.cc changes are OK. But my personal opinion is that the whole patch is obviously OK and after bootstrapping it you can check it in as such. Martin > * langhooks.cc: Likewise. > * lto-streamer-in.cc: Likewise. > * print-rtl.cc: Likewise. > * rtl-tests.cc: Likewise. > * sanopt.cc: Likewise. > * stmt.cc: Likewise. > * targhooks.cc: Likewise. > * tree-diagnostic-cfg.cc: Likewise. > * tree-if-conv.cc: Likewise. > * tree-ssa-threadupdate.cc: Likewise. > * tree-vect-patterns.cc: Likewise. > * tree.cc: Likewise. > * varasm.cc: Likewise. > > gcc/cp/ChangeLog: > > * call.cc: Remove unused include directives. > * init.cc: Likewise. > * semantics.cc: Likewise. > --- > gcc/caller-save.cc | 1 - > gcc/cp/call.cc | 1 - > gcc/cp/init.cc | 1 - > gcc/cp/semantics.cc | 1 - > gcc/cse.cc | 1 - > gcc/dwarf2ctf.cc | 1 - > gcc/function-tests.cc | 9 --------- > gcc/gimple-pretty-print.cc | 3 +-- > gcc/gimple-range-trace.cc | 1 - > gcc/gimple-range.cc | 1 - > gcc/gimple-ssa-store-merging.cc | 1 - > gcc/ipa-devirt.cc | 1 - > gcc/ipa-inline-transform.cc | 1 - > gcc/langhooks.cc | 1 - > gcc/lto-streamer-in.cc | 1 - > gcc/print-rtl.cc | 1 - > gcc/rtl-tests.cc | 1 - > gcc/sanopt.cc | 1 - > gcc/stmt.cc | 1 - > gcc/targhooks.cc | 1 - > gcc/tree-diagnostic-cfg.cc | 1 - > gcc/tree-if-conv.cc | 1 - > gcc/tree-ssa-threadupdate.cc | 1 - > gcc/tree-vect-patterns.cc | 2 -- > gcc/tree.cc | 1 - > gcc/varasm.cc | 1 - > 26 files changed, 1 insertion(+), 36 deletions(-) >
