On Mon, Oct 05, 2026 at 12:04:09PM +0100, Tamar Christina wrote:
> The fix for PR123457 to fix PCH was only partial. While it added the table
> pointers to GTY so they're tracked as roots, it didn't fix the pointers of the
> nested classes that are used as hashes for the object.
Thanks for working on this.
> The documentation states that GTY((callback)) can only be used for function
> pointers so can't be used for data pointers. The base class is marked
The documentation can be changed or the flag renamed if needed, we don't
have that many uses of it anyway. That said, given the user marking
> GTY((user)) anyway. The easiest fix is dropping the pointers from the
> calculation of the hash, however this weakens the hash function.
I think what you did in the patch is best.
Jakub
