I took the liberty of CC:ing maintainers for hppa and sparc (xfail
markers), in case they're interested in verifying that PR 84877 is
indeed fixed for them too.  And, to the patch author: thanks!  This
was an old headache for which a fix was once even reverted.

brgds, H-P

-- >8 --
Commit r17-4649-g8aaa5f6e62075c fixed PR 84877 for cris-elf, and very
likely the other targets for which this test was marked xfail.
Beware: it may have passed (or XPASSed) for sparc for the wrong reason
before, if the stack was aligned by chance; see the stabilization
machinery (which is enabled only for cris-*-*).

Besides executing the result in a similator, I inspected assembly
before/after r17-4649 with/without -DDO_NOT_TAMPER (which disables the
machinery), to check that there wasn't some obvious bug causing the
test to pass.  The result simply looks correct.

gcc/testsuite:
        PR middle-end/84877
        * gcc.dg/pr84877.c: Remove xfail for cris-*-*.
---
 gcc/testsuite/gcc.dg/pr84877.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/pr84877.c b/gcc/testsuite/gcc.dg/pr84877.c
index 2f2e29578df9..33007cc256fb 100644
--- a/gcc/testsuite/gcc.dg/pr84877.c
+++ b/gcc/testsuite/gcc.dg/pr84877.c
@@ -1,4 +1,4 @@
-/* { dg-do run { xfail { { cris-*-* sparc*-*-* } || { { ! lp64 } && hppa*-*-* 
} } } } */
+/* { dg-do run { xfail { { sparc*-*-* } || { { ! lp64 } && hppa*-*-* } } } } */
 /* { dg-options "-O2" } */
 
 #include <inttypes.h>
-- 
2.43.0

Reply via email to