Hi Roger, > This patch tweaks aarch64.md to ensure it is AOP-safe, i.e. can recognize > bfi, bfxil and rev16 instructions when expressed in RTL using either PLUS, > IOR or XOR. My already approved patch for PR tree-optimization/108477 > will cause 8 testsuite regressions on aarch64, and this patch addresses > the machine description issues and resolves/prevents 2 of those 8 FAILs.
Thanks, the patch is quite simple, so this is OK. One minor nitpick, could you use a slightly clearer title in the commit? Eg. "AArch64: Change the bitfield patterns to be any-or-plus (AOP) safe" Cheers, Wilco
