Hi Ezra,
On 09/09/2026 14:31, [email protected] wrote:
> From: Ezra Sitorus <[email protected]>
>
> Add support for these new pairwise intrinsic operations: svaddqp, svaddsubp
> and
> svsubp.
>
> Changes from v2:
> * Make it compatible with recent changes in SVE framework.
>
> gcc/ChangeLog:
> * config/aarch64/aarch64-sve-builtins-sve2.cc
> (svsubp, svaddqp, svaddsubp): Define new function base.
> * config/aarch64/aarch64-sve-builtins-sve2.def
> (svaddqp, svaddsubp, svsubp): Define new SVE functions.
> * config/aarch64/aarch64-sve-builtins-sve2.h
> (svaddqp, svaddsubp, svsubp): Declare new function base.
> * config/aarch64/aarch64-sve2.md
> (@aarch64_sve_<sve_int_op><mode>): New.
> * config/aarch64/iterators.md
> (UNSPEC_ADDQP): New unspec.
> (UNSPEC_ADDSUBP): Likewise.
> (UNSPEC_SUBP): Likewise.
> (SVE2_INT_BINARY_PAIR): Add UNSPEC_SUBP.
> (SVE2p3_INT_BINARY_PAIR_UNPRED): New int iterator.
> (sve_int_op): Add new unspec variants.
>
> gcc/testsuite/ChangeLog:
> * gcc.target/aarch64/sve2/acle/asm/addqp.c: New test.
> * gcc.target/aarch64/sve2/acle/asm/addsubp.c: Likewise.
> * gcc.target/aarch64/sve2/acle/asm/subp.c: Likewise.
> ---
> .../aarch64/aarch64-sve-builtins-sve2.cc | 3 +
> .../aarch64/aarch64-sve-builtins-sve2.def | 6 +
> .../aarch64/aarch64-sve-builtins-sve2.h | 3 +
> gcc/config/aarch64/aarch64-sve2.md | 15 ++
> gcc/config/aarch64/iterators.md | 10 ++
> .../gcc.target/aarch64/sve2/acle/asm/addqp.c | 99 +++++++++++++
> .../aarch64/sve2/acle/asm/addsubp.c | 99 +++++++++++++
> .../gcc.target/aarch64/sve2/acle/asm/subp.c | 132 ++++++++++++++++++
> 8 files changed, 367 insertions(+)
> create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/addqp.c
> create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/addsubp.c
> create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/subp.c
>
> diff --git a/gcc/config/aarch64/aarch64-sve-builtins-sve2.cc
> b/gcc/config/aarch64/aarch64-sve-builtins-sve2.cc
> index 0b59de34e056..87c7f0319925 100644
> --- a/gcc/config/aarch64/aarch64-sve-builtins-sve2.cc
> +++ b/gcc/config/aarch64/aarch64-sve-builtins-sve2.cc
> @@ -1068,6 +1068,8 @@ FUNCTION (svaddlbt, unspec_based_function,
> (UNSPEC_SADDLBT))
> FUNCTION (svaddlt, unspec_based_function, (UNSPEC_SADDLT, UNSPEC_UADDLT))
> FUNCTION (svaddp, unspec_based_pred_function, (UNSPEC_ADDP, UNSPEC_ADDP,
> UNSPEC_FADDP))
> +FUNCTION (svaddqp, unspec_based_function, (UNSPEC_ADDQP, UNSPEC_ADDQP))
> +FUNCTION (svaddsubp, unspec_based_function, (UNSPEC_ADDSUBP, UNSPEC_ADDSUBP))
> FUNCTION (svaddqv, reduction, (UNSPEC_ADDQV, UNSPEC_ADDQV, UNSPEC_FADDQV))
> FUNCTION (svaddwb, unspec_based_function, (UNSPEC_SADDWB, UNSPEC_UADDWB))
> FUNCTION (svaddwt, unspec_based_function, (UNSPEC_SADDWT, UNSPEC_UADDWT))
> @@ -1322,6 +1324,7 @@ FUNCTION (svsublt, unspec_based_function,
> (UNSPEC_SSUBLT, UNSPEC_USUBLT))
> FUNCTION (svsubltb, unspec_based_function, (UNSPEC_SSUBLTB))
> FUNCTION (svsubwb, unspec_based_function, (UNSPEC_SSUBWB, UNSPEC_USUBWB))
> FUNCTION (svsubwt, unspec_based_function, (UNSPEC_SSUBWT, UNSPEC_USUBWT))
> +FUNCTION (svsubp, unspec_based_pred_function, (UNSPEC_SUBP, UNSPEC_SUBP))
> FUNCTION (svtbl2, svtbl2_impl,)
> FUNCTION (svtblq, quiet<unspec_based_uncond_function>, (UNSPEC_TBLQ,
> UNSPEC_TBLQ,
> diff --git a/gcc/config/aarch64/aarch64-sve-builtins-sve2.def
> b/gcc/config/aarch64/aarch64-sve-builtins-sve2.def
> index 6ed9243c8dc0..8b5340f4e30a 100644
> --- a/gcc/config/aarch64/aarch64-sve-builtins-sve2.def
> +++ b/gcc/config/aarch64/aarch64-sve-builtins-sve2.def
> @@ -298,6 +298,12 @@ DEF_SVE_FUNCTION_GS (svwhilelt, compare_scalar, while_x,
> x2, none)
> DEF_SVE_FUNCTION (svwhilelt, compare_scalar_count, while_x_c, none)
> #undef REQUIRED_EXTENSIONS
>
> +#define REQUIRED_EXTENSIONS sve_and_sme (AARCH64_FL_SVE2p3,
> AARCH64_FL_SME2p3)
> +DEF_SVE_FUNCTION (svaddqp, binary, all_integer, none)
> +DEF_SVE_FUNCTION (svaddsubp, binary, all_integer, none)
> +DEF_SVE_FUNCTION (svsubp, binary, all_integer, mx)
> +#undef REQUIRED_EXTENSIONS
> +
> #define REQUIRED_EXTENSIONS nonstreaming_sve (AARCH64_FL_SVE2p1)
> DEF_SVE_FUNCTION (svld1q_gather, load_gather64_sv_offset, all_data, implicit)
> DEF_SVE_FUNCTION (svld1q_gather, load_gather64_sv_index, hsd_data, implicit)
> diff --git a/gcc/config/aarch64/aarch64-sve-builtins-sve2.h
> b/gcc/config/aarch64/aarch64-sve-builtins-sve2.h
> index 393c2c8ca2c8..b6ddba43f229 100644
> --- a/gcc/config/aarch64/aarch64-sve-builtins-sve2.h
> +++ b/gcc/config/aarch64/aarch64-sve-builtins-sve2.h
> @@ -38,6 +38,8 @@ namespace aarch64_acle
> extern const function_base *const svaddlb;
> extern const function_base *const svaddlbt;
> extern const function_base *const svaddlt;
> + extern const function_base *const svaddqp;
> + extern const function_base *const svaddsubp;
> extern const function_base *const svaddp;
> extern const function_base *const svaddqv;
> extern const function_base *const svaddwb;
> @@ -249,6 +251,7 @@ namespace aarch64_acle
> extern const function_base *const svsublbt;
> extern const function_base *const svsublt;
> extern const function_base *const svsubltb;
> + extern const function_base *const svsubp;
> extern const function_base *const svsubwb;
> extern const function_base *const svsubwt;
> extern const function_base *const svtbl2;
> diff --git a/gcc/config/aarch64/aarch64-sve2.md
> b/gcc/config/aarch64/aarch64-sve2.md
> index a976a9e7a852..0e11347098db 100644
> --- a/gcc/config/aarch64/aarch64-sve2.md
> +++ b/gcc/config/aarch64/aarch64-sve2.md
> @@ -3292,8 +3292,11 @@
> ;; - ADDP
> ;; - SMAXP
> ;; - SMINP
> +;; - SUBP
> ;; - UMAXP
> ;; - UMINP
> +;; - ADDQP
> +;; - ADDSUBP
> ;; -------------------------------------------------------------------------
>
> (define_insn "@aarch64_pred_<sve_int_op><mode>"
> @@ -3311,6 +3314,18 @@
> [(set_attr "sve_type" "sve_int_general")]
> )
>
> +(define_insn "@aarch64_sve_<sve_int_op><mode>"
> + [(set (match_operand:SVE_FULL_I 0 "register_operand")
> + (unspec:SVE_FULL_I
> + [(match_operand:SVE_FULL_I 1 "register_operand")
> + (match_operand:SVE_FULL_I 2 "register_operand")]
> + SVE2p3_INT_BINARY_PAIR_UNPRED))]
> + "TARGET_SVE2p3_OR_SME2p3"
> + {@ [ cons: =0 , 1 , 2 ; attrs: movprfx ]
> + [ w , w , w ; * ] <sve_int_op>\t%0.<Vetype>,
> %1.<Vetype>, %2.<Vetype>
> + }
> + [(set_attr "sve_type" "sve_int_general")]
> +)
Can't we just extend the SVE2_INT_TERNARY iterator to add ADD{Q,SUB}P
support, similar to how you extended the SVE2_INT_BINARY_PAIR iterator
to add SUBP support below?
Otherwise the patch LGTM with Artemiy's comments addressed, too.
Thanks,
Alex
> ;; -------------------------------------------------------------------------
> ;; ---- [FP] Pairwise arithmetic
> ;; -------------------------------------------------------------------------
> diff --git a/gcc/config/aarch64/iterators.md b/gcc/config/aarch64/iterators.md
> index 06e8746e1436..ef31f513d08a 100644
> --- a/gcc/config/aarch64/iterators.md
> +++ b/gcc/config/aarch64/iterators.md
> @@ -1350,7 +1350,9 @@
> UNSPEC_PERMUTE_PRED
>
> ;; All used in aarch64-sve2.md
> + UNSPEC_ADDQP
> UNSPEC_ADDQV
> + UNSPEC_ADDSUBP
> UNSPEC_ANDQV
> UNSPEC_DUPQ
> UNSPEC_EORQV
> @@ -1380,6 +1382,7 @@
> UNSPEC_ST1_TRUNCQ
> UNSPEC_ST1Q_SCATTER
> UNSPEC_STNQ
> + UNSPEC_SUBP
> UNSPEC_UMAXQV
> UNSPEC_UMINQV
> UNSPEC_UQCVT
> @@ -4110,9 +4113,13 @@
> (define_int_iterator SVE2_INT_BINARY_PAIR [UNSPEC_ADDP
> UNSPEC_SMAXP
> UNSPEC_SMINP
> + (UNSPEC_SUBP
> "TARGET_SVE2p3_OR_SME2p3")
> UNSPEC_UMAXP
> UNSPEC_UMINP])
>
> +(define_int_iterator SVE2p3_INT_BINARY_PAIR_UNPRED [UNSPEC_ADDSUBP
> + UNSPEC_ADDQP])
> +
> (define_int_iterator SVE2_FP_BINARY_PAIR [UNSPEC_FADDP
> UNSPEC_FMAXP
> UNSPEC_FMAXNMP
> @@ -4996,6 +5003,9 @@
> (UNSPEC_ADCLT "adclt")
> (UNSPEC_ADDHNB "addhnb")
> (UNSPEC_ADDHNT "addhnt")
> + (UNSPEC_ADDQP "addqp")
> + (UNSPEC_ADDSUBP "addsubp")
> + (UNSPEC_SUBP "subp")
> (UNSPEC_ADDP "addp")
> (UNSPEC_ANDV "andv")
> (UNSPEC_ASHIFTRT_WIDE "asr")
<snip>
