在 2026/10/14 21:57, Richard Biener 写道: > On Wed, Oct 14, 2026 at 9:40 AM Kewen Lin <[email protected]> wrote: >> >> 在 2026/10/14 14:08, Richard Biener 写道: >>> On Wed, Oct 14, 2026 at 3:54 AM Kewen Lin <[email protected]> wrote: >>>> >>>> 在 2026/10/13 17:08, Richard Biener 写道: >>>>> On Tue, Oct 13, 2026 at 9:50 AM Kewen Lin <[email protected]> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> When adding vector math lib support, I found trigonometric pi-based >>>>>> functions introduced by r16-710-g591d3d02664c7b are missing from >>>>>> macro SEQ_OF_CASE_MATHFN in function mathfn_built_in_2, which caused >>>>>> ICE as hanlder assumes there is a non-null function declaration but >>>>>> actually mathfn_built_in cannot map their combined_fn codes to >>>>>> type-specific builtin declarations. >>>>>> >>>>>> I think this is an oversight, so this patch is to add those >>>>>> trigonometric pi-based builtins to SEQ_OF_CASE_MATHFN, and keep >>>>>> builtin_with_linkage_p in sync as well. >>>>>> >>>>>> Bootstrapped and the regression-tested well, is it ok for trunk? >>>>> >>>>> OK. >>>> >>>> Thanks Richi, pushed as r17-5176-g10e202e107d23a. >>>> >>>> Do we want it to be backported to gcc-16 branch? >>>> If yes, is it ok to backport after burn-in time? >>> >>> Can you add a testcase then? Then it's OK to backport. >> >> Sure, without the VML change, it seems no way to construct a test case >> for showing ICE, so I didn't include a testcase in the original patch. >> With AI's assistance, I have now constructed a testcase for the >> builtin_with_linkage_p path instead, so a follow-up patch for test >> case is listed below. Is it ok for trunk and backporting? > > OK.
Thanks again, pushed as r17-5210-g3d0eda79500695. BR, Kewen
