Hi Andrew, On Wed, 18 Sep 2024, Andrew Kreimer wrote: > Fix a typo in comments. > > Signed-off-by: Andrew Kreimer <[email protected]> > --- > libcc1/configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > # basename: Compute filename of FILE. > -# value retuned in "$func_basename_result" > +# value returned in "$func_basename_result" > # Implementation must be kept synchronized with func_dirname
I noticed nobody took care of this patch, presumably because the diagnosis is correct, alas the way of fixing it is not. libcc1/configure is a file generated from others, and as % git grep "value retuned in" $GCC_SOURCE shows there is a good number of other places in the GCC codebase affected similarly: libatomic/configure:# value retuned in "$func_basename_result" libbacktrace/configure:# value retuned in "$func_basename_result" libcc1/configure:# value retuned in "$func_basename_result" libffi/configure:# value retuned in "$func_basename_result" libga68/configure:# value retuned in "$func_basename_result" libgcobol/configure:# value retuned in "$func_basename_result" libgfortran/configure:# value retuned in "$func_basename_result" libgm2/configure:# value retuned in "$func_basename_result" libgo/config/libtool.m4:# value retuned in "$func_basename_result" libgo/config/ltmain.sh:# value retuned in "$func_basename_result" libgo/configure:# value retuned in "$func_basename_result" libgomp/configure:# value retuned in "$func_basename_result" libgrust/configure:# value retuned in "$func_basename_result" libitm/configure:# value retuned in "$func_basename_result" libobjc/configure:# value retuned in "$func_basename_result" libphobos/configure:# value retuned in "$func_basename_result" libquadmath/configure:# value retuned in "$func_basename_result" libsanitizer/configure:# value retuned in "$func_basename_result" libssp/configure:# value retuned in "$func_basename_result" libstdc++-v3/configure:# value retuned in "$func_basename_result" libtool.m4:# value retuned in "$func_basename_result" libvtv/configure:# value retuned in "$func_basename_result" ltmain.sh:# value retuned in "$func_basename_result" lto-plugin/configure:# value retuned in "$func_basename_result" zlib/configure:# value retuned in "$func_basename_result" Of these only libtool.m4 and ltmain.sh are not generated configure scripts, and https://gcc.gnu.org/codingconventions.html documents upstream GNU libtool as their source. I used https://www.gnu.org/software/libtool/libtool.html for instructions on how to check out the libtool codebase and it appears things have changed very significantly from what GCC carries – the string "retune" does not appear anywhere So this should be fixed whenever there's a wholesale sync from upstream libtool, When (or whether) this is going to happen, I don't know. Gerald
