Hi Andrew! I've checked the changes to tree-ssa-structalias.cc and tree-ssa-alias.h and they look ok. I don't know tree-ssa-alias.cc well, so I can't vouch for those changes, but I've also looked and they look straightforward and ok. I haven't looked at the other changes. I have no experience with tree-data-ref.cc for instance.
Overall, abstracting away ptr_info_def sounds like a good idea to me. The code becomes more straightforward. But again, I don't want to vouch for that. Maybe there are some problematic consequences I don't see. I would wait for what Richard says about this. Btw, I also plan to post a patch that kind of refactors tree-ssa-structalias.cc and tree-ssa-alias.h soon. I'm not sure when you plan to get this merged, but this is a heads-up that there will be merge conflicts (nothing too complicated, I think) that you might have to solve if I happen to be faster. Have a nice day, Filip Kastl
