On 11/11/2026 18:53, Andrea Pinski wrote:
Did this change in C++17 over C++14? Or was this in C++14 still? Does this fix say compiling GCC with GCC 5.4? Or with clang?
Thanks for the review. I should correct my description of the standards requirement. The published C++14, C++17 and C++20 wording of [namespace.udecl]/17 required the base class members named by a using-declaration to be visible in the scope of at least one direct base class. P1787R6 removed this restriction as a defect report. So the restriction was present in both C++14 and C++17. This is not a GCC or Clang failure; GCC (including 5.4) and Clang accept the existing code. EDG based compilers still enforce the restriction in modes before C++23.
I think this is obvious otherwise. But I think you should expand on the commit message of why the change is needed; e.g. where this was changed. Also you didn't describe how you tested the patch.
To check the fix itself, I compiled gimple-range-op.cc with an EDG-based compiler (the existing code is rejected, the patched form is accepted), and checked that GCC and Clang accept both forms. For regressions, v1 was bootstrapped and regression-tested on aarch64-unknown-linux-gnu. I'll send a v2 with the corrected explanation.
