On Thu, Nov 12, 2026 at 03:49:43PM +0000, Guillaume Gomez via Sourceware Forge wrote: > From: Guillaume Gomez <[email protected]> > > gcc/jit/ChangeLog: > > * dummy-frontend.cc (handle_cold_attribute, handle_format_arg_attribute) > (handle_format_attribute, handle_nonnull_attribute) > (handle_noreturn_attribute, handle_patchable_function_entry_attribute) > (handle_sentinel_attribute, handle_transaction_pure_attribute) > (jit_handle_cold_attribute, jit_handle_format_arg_attribute) > (jit_handle_format_attribute, jit_handle_nonnull_attribute) > (jit_handle_noreturn_attribute) > (jit_handle_patchable_function_entry_attribute) > (jit_handle_sentinel_attribute, jit_handle_transaction_pure_attribute): > Prepend functions with `jit_` > --- > Follow-up of https://forge.sourceware.org/gcc/gcc/pulls/273 and of #274. > > @dkm (promise it's the last time I ping you for today 😆) suggested > [here](https://forge.sourceware.org/gcc/gcc/pulls/244#issuecomment-7865) to > prepend all Ada attribute handling functions to prevent name conflicts and I > think it's a very good idea, so I'm doing it here as well. > > cc @dmalcolm > > > > This is a forge pull request published on the gcc-patches mailing list > mailing list > as requested by Guillaume Gomez via Sourceware Forge > <[email protected]>. > Forge discussion: https://forge.sourceware.org/gcc/gcc/pulls/275 > > Get it locally using: > ``` > git fetch forge-upstream > "+refs/versioned_pull/275/*:refs/versioned_pull/275/*" > git switch -c "pr-275-v1" "refs/versioned_pull/275/1/head" > ``` > Or, download the patch at: https://forge.sourceware.org/gcc/gcc/pulls/275.diff > Created on: 2026-11-12 15:49:04+00:00 > Latest update: 2026-11-12 15:49:43+00:00 > Changes: 1 changed files, 40 additions, 39 deletions > Head revision: imperio/gcc ref jit-attr-conflict commit > a67dcd71eb48f316575f3be8413a2066e5f8046b > Base revision: gcc/gcc ref trunk commit > d20952792b133c691be69a2bfdb71e1956592956 r17-6173-gd20952792b133c > Merge base: d20952792b133c691be69a2bfdb71e1956592956 > Requested Reviewers: > > Changed files: > - M: gcc/jit/dummy-frontend.cc > > gcc/jit/dummy-frontend.cc | 79 ++++++++++++++++++++------------------- > 1 file changed, 40 insertions(+), 39 deletions(-) > > diff --git a/gcc/jit/dummy-frontend.cc b/gcc/jit/dummy-frontend.cc > index a3140c4198777..0b221306f1351 100644 > --- a/gcc/jit/dummy-frontend.cc > +++ b/gcc/jit/dummy-frontend.cc > @@ -44,15 +44,16 @@ using namespace gcc::jit; > /* Attribute handling. These are the libgccjit-specific attribute handlers; > the handlers shared with the C family live in gcc/attr-handlers.cc. */ > > -static tree handle_cold_attribute (tree *, tree, tree, int, bool *); > -static tree handle_format_arg_attribute (tree *, tree, tree, int, bool *); > -static tree handle_format_attribute (tree *, tree, tree, int, bool *); > -static tree handle_nonnull_attribute (tree *, tree, tree, int, bool *); > -static tree handle_noreturn_attribute (tree *, tree, tree, int, bool *); > -static tree handle_patchable_function_entry_attribute (tree *, tree, tree, > - int, bool *); > -static tree handle_sentinel_attribute (tree *, tree, tree, int, bool *); > -static tree handle_transaction_pure_attribute (tree *, tree, tree, int, bool > *); > +static tree jit_handle_cold_attribute (tree *, tree, tree, int, bool *); > +static tree jit_handle_format_arg_attribute (tree *, tree, tree, int, bool > *); > +static tree jit_handle_format_attribute (tree *, tree, tree, int, bool *); > +static tree jit_handle_nonnull_attribute (tree *, tree, tree, int, bool *); > +static tree jit_handle_noreturn_attribute (tree *, tree, tree, int, bool *); > +static tree jit_handle_patchable_function_entry_attribute (tree *, tree, > tree, > + int, bool *); > +static tree jit_handle_sentinel_attribute (tree *, tree, tree, int, bool *); > +static tree jit_handle_transaction_pure_attribute (tree *, tree, tree, int, > + bool *);
perhaps bikesheding, but static functions with prefixs like this seems weird, and I'd think the more natural thing would be to rename the ones in attr-handlers.h to common_handle_x or handle_x_common? thanks Trev
