On Wed, Oct 31, 2012 at 10:59 AM, Richard Sandiford <rdsandif...@googlemail.com> wrote: > Richard Biener <richard.guent...@gmail.com> writes: >> On Tue, Oct 30, 2012 at 10:05 PM, Kenneth Zadeck >> <zad...@naturalbridge.com> wrote: >>> jakub, >>> >>> i am hoping to get the rest of my wide integer conversion posted by nov 5. >>> I am under some adverse conditions here: hurricane sandy hit her pretty >>> badly. my house is hooked up to a small generator, and no one has any power >>> for miles around. >>> >>> So far richi has promised to review them. he has sent some comments, but >>> so far no reviews. Some time after i get the first round of them posted, >>> i will do a second round that incorporates everyones comments. >>> >>> But i would like a little slack here if possible. While this work is a >>> show stopper for my private port, the patches address serious problems for >>> many of the public ports, especially ones that have very flexible vector >>> units. I believe that there are significant set of latent problems >>> currently with the existing ports that use ti mode that these patches will >>> fix. >>> >>> However, i will do everything in my power to get the first round of the >>> patches posted by nov 5 deadline. >> >> I suppose you are not going to merge your private port for 4.8 and thus >> the wide-int changes are not a show-stopper for you. >> >> That said, I considered the main conversion to be appropriate to be >> defered for the next stage1. There is no advantage in disrupting the >> tree more at this stage. > > I would like the wide_int class and rtl stuff to go in 4.8 though. > IMO it's a significant improvement in its own right, and Kenny > submitted it well before the deadline.
If it gets in as-is then we'll have to live with the IMHO broken API (yet another one besides the existing double-int). So _please_ shrink the API down aggresively in favor of using non-member helper functions with more descriptive names for things that lump together multiple operations. Look at double-int and use the same API ideas as people are familiar with it (like the unsigned flag stuff) - consistency always trumps. I'm going to be on vacation for the next three weeks so somebody else has to pick up the review work. But I really think that the tree has to recover from too many changes already. Richard.
