Hi Joseph, Can you please review this patch? If I missed something, please point out. Thanks.
BR, Terry > -----Original Message----- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Terry Guo > Sent: Friday, November 23, 2012 5:12 PM > To: jos...@codesourcery.com > Cc: gcc-patches@gcc.gnu.org > Subject: Ping: RE: [RFC] New feature to reuse one multilib among > different targets > > Hi Joseph, > > Can you please help to review this patch and share your thoughts on > this > feature? Thanks. > > BR, > Terry > > > -----Original Message----- > > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > > ow...@gcc.gnu.org] On Behalf Of Terry Guo > > Sent: Tuesday, November 13, 2012 12:47 PM > > To: jos...@codesourcery.com > > Cc: gcc-patches@gcc.gnu.org > > Subject: RE: [RFC] New feature to reuse one multilib among different > > targets > > > > > -----Original Message----- > > > From: Joseph Myers [mailto:jos...@codesourcery.com] > > > Sent: Saturday, November 10, 2012 12:35 AM > > > To: Terry Guo > > > Cc: gcc-patches@gcc.gnu.org > > > Subject: RE: [RFC] New feature to reuse one multilib among > different > > > targets > > > > > > On Fri, 9 Nov 2012, Terry Guo wrote: > > > > > > > You are right that we should make script POSIX compliant. This v3 > > > patch > > > > removed "function" and "local" which don't belong to POSIX > standard. > > > I also > > > > verified that CONFIG_SHELL is passed to this script with value > > > "/bin/sh". > > > > > > Suppose /bin/sh is not a POSIX shell but the user sets CONFIG_SHELL > > to > > > something else (which is a POSIX shell). Will SHELL in the > makefile > > > get set to the POSIX shell the user specified as CONFIG_SHELL? > > That's > > > what's needed to be able to use POSIX shell features in this script. > > > > > > > The attached patch is updated to use sub-script rather than the > > function to > > reuse code. Is it ok to avoid the issue you just mentioned? > > > > BR, > > Terry > > > > 2012-11-13 Terry Guo <terry....@arm.com> > > > > * genmultilib (tmpmultilib3): New refactored sub-script > > to convert the option combination into folder name. > > (tmpmultilib4): New refactored sub-script to output the > > options in a option combination. > > (MULTILIB_REUSE): New argument. > > * Makefile.in (s-mlib): Add a new argument MULTILIB_REUSE. > > * gcc.c (multilib_reuse): New spec. > > (set_multilib_dir): Use multilib_reuse. > > * doc/fragments.texi: Mention MULTILIB_REUSE. > >
