On 12/13/12, Martin Jambor <mjam...@suse.cz> wrote:
> On Thu, Dec 13, 2012 at 11:05:49AM -0800, Lawrence Crowl wrote:
> > On 12/12/12, Jakub Jelinek <ja...@redhat.com> wrote:
> > > On Tue, Dec 11, 2012 at 02:44:41PM -0800, Lawrence Crowl wrote:
> > > > +/* Hash a tree in a uid_decl_map. */
> > > > +
> > > > +inline hashval_t
> > > > +uid_decl_hasher::hash (const value_type *item)
> > > > +{
> > > > + return item->decl_minimal.uid;
> > >
> > > Ugh, why aren't you using DECL_UID here? The fact that DECL_UID is
> > > right now defined to (DECL_MINIMAL_CHECK (NODE)->decl_minimal.uid)
> > > might change, we really don't want to update thousands of locations
> > > should we need to change that.
> >
> > That is what the code looked like in its original location. I have
> > resisted making changes not essential to the purpose of the patch.
> > However, if you want me to change it to use DECL_UID, I will.
>
> Yes, I think it ought to be changed.
> Thanks for the conversion,
It turns out that making the change causes the check to fail.
Therefore, I will leave the code alone and let someone more familiar
with the code investigate.
--
Lawrence Crowl
