On Thu, Dec 13, 2012 at 10:12 AM, Bernhard Reutner-Fischer
<rep.dot....@gmail.com> wrote:
> On Fri, Dec 07, 2012 at 10:31:57AM -0500, Diego Novillo wrote:
>>On Thu, Dec 6, 2012 at 1:12 PM, Bernhard Reutner-Fischer
>><rep.dot....@gmail.com> wrote:
>
> @@ -210,12 +211,12 @@ def IsInterestingResult(line):
> if '|' in line:
> (_, line) = line.split('|', 1)
> line = line.strip()
> - return any(line.startswith(result) for result in _VALID_TEST_RESULTS)
> + return bool(_VALID_TEST_RESULTS_REX.match(line))
>
> I wonder why we care about '|' at all? Can you give an example where
> this is of relevance?
That's for the attributes. See the syntax at the top of the file.
One can add an attribute to a test. For instance, mark it 'flaky' so
it's always ignored. Or you can add an expiration date, to ignore it
until that timer elapses.
> or, if there ever is a pipe in an interesting result
> def IsInterestingResult(line):
> """Return True if line is one of the summary lines we care about."""
> if bool(_VALID_TEST_RESULTS_REX.match(line)):
> if '|' in line:
> (line, _) = line.split('|', 1)
> line = line.strip()
> return True
> return False
*shrug*
Performance is not really a problem with this script.
Diego.
