Hi Kai,
>>> Index: gcc.target/i386/pr20020-1.c
>>> ===================================================================
>>> --- gcc.target/i386/pr20020-1.c (Revision 196507)
>>> +++ gcc.target/i386/pr20020-1.c (Arbeitskopie)
>>> @@ -1,5 +1,6 @@
>>> /* Check that 128-bit struct's are represented as TImode values. */
>>> /* { dg-do compile { target int128 } } */
>>> +/* { dg-skip-if "" { x86_64-*-mingw* } { "*" } { "" } } */
>>
>> Please omit the default { "*" } { "" } here and in other tests below.
>> And again: explain why the test is skipped.
>
> Hmm, why shall I omit here the default. I checked in tree and most
> statements for dg-skip-if are expressing default too.
just because support for omitting the default isn't that old. There's
certainly opportunity for cleanup, but we shouldn't spread this any
further.
> Well, to skip here x64 mingw is caused by the fact that it has a
> different ABI as x86_64. I will add it to skip message.
Thanks. It's always far easier to have this in the testsuite to spare
the next guy from doing software archaeology.
> Ok to apply with those changes?
Again, I prefer to defer to the target maintainers.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
