On 2013-05-30 04:32, Ian Bolton wrote:
On 05/20/2013 11:55 AM, Ian Bolton wrote:
> >I improved this patch during the work I did on the recent insv_imm
>patch
> >(http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01007.html).
>
>Thanks, you cleaned up almost everything on which I would have
>commented
>with the previous patch revision. The only thing left is:
>
> >+ else if (!register_operand (value, <MODE>mode))
> >+ operands[3] = force_reg (<MODE>mode, value);
>
>Checking register_operand before force_reg is unnecessary; you're not
>saving a
>function call, and force_reg will itself perform the register check.
Thanks for the review, Richard.
Latest patch is attached, which fixes this.
Linux and bare-metal regression runs successful.
Ok.
r~
