On Wed, May 29, 2013 at 11:35:29AM +0200, Uros Bizjak wrote:
> > 2013-05-27 Yuri Rumyantsev <yuri.s.rumyant...@intel.com>
> > Igor Zamyatin <igor.zamya...@intel.com>
Much more importantly,
> > (fold_builtin_cpu): Add slm.
the above:
> > * libgcc/config/i386/cpuinfo.c (INTEL_SLM): New enum value.
and the above changes look to me like ABI breaking.
You can't insert any values in the middle of the ranges, so M_SLM can't be
inserted in between M_INTEL_ATOM and M_INTEL_CORE2, but needs to go
right before M_CPU_SUBTYPE_START, similarly in cpuinfo.c needs to go right
before CPU_TYPE_MAX, otherwise if you use older compiled programs against
newer libgcc or vice versa, the CPU detection will not work properly.
It would be nice to either insert a comment saying that new items can be
only inserted at end, or add explicit = 2 etc. to the enums, or both
to make it clear that the values are part of ABI and must not be ever
changed.
Plus, the latter ChangeLog entry should have been just
* config/i386/cpuinfo.c (INTEL_SLM): New enum value.
and should have gone into libgcc/ChangeLog.
Jakub
