"Jürgen Urban" <juergenur...@gmx.de> writes: > Hello Richard, > >> Thanks, looks good. The comments I have are only minor and seemed easier >> to spell out as a revised patch, attached below. The changes are: >> >> * removing the config.sub bit, which looked redundant. We already have >> the up-to-date upstream config.sub. >> >> * removing the target_cpu_default setting. I realise this was taken >> from mips64-elf, but it was redundant here, there, and elsewhere. >> I've just committed a patch to remove the existing cases. >> >> * removing the TUNE_5900 definition. I prefer not to define these >> kinds of macro until they're used. >> >> * removing the ISA_HAS_LDC1_SDC1 setting. I realise what you did >> describes the reality of the processor, but the problem is that >> the patch doesn't provide an alternative for 64-bit loads and >> stores when -mfp64 is used. That combination also isn't rejected, >> so we're likely to get an internal compiler error instead. >> >> This change shouldn't affect the soft-float case you describe. >> It also shouldn't be important for the single-float code. >> >> * tweaking the mips_reorg_process_insns comment slightly >> >> * fixing a few minor formatting issues >> >> Does this version look OK to you? I'll commit it if so. > > This is OK and the generated code is still working on the PS2 in my test run.
Thanks, now applied. >> FWIW, the Cygnus/Red Hat version of the port just stuck with the R5900 >> behaviour and made GCC understand it (MODE_HAS_* & various other bits). >> This code was then updated and extended for the SPU. I'd have expected >> the support to be in reasonably good shape because of the SPU. > > I assume that you mean the cell processor of the PS3 and not the Sound > Processing Unit of the PS2. :-) > The macros MODE_HAS_* in the GCC look promising. You've probably already seen it, but there's also spu_single_format. Richard
