On 6/10/13 8:32 AM, Richard Earnshaw wrote: > On 07/06/13 17:50, Cesar Philippidis wrote: >> On 6/6/13 9:00 AM, Richard Earnshaw wrote: >>> The pipeline offset is 4 for Thumb2 as well. So at the very least you >>> need to explain why your change doesn't apply then as well. >> >> Yes some context is lost in that comment. Thunks are usually emitted in >> ARM mode, except for Thumb-only targets. Is the new comment OK? If so, >> please check it in since I do not have SVN write access. >> > > So what about ARMv7-M, which is thumb2 but no ARM state?
Thumb2 is handled differently. This patch is inside an if (TARGET_THUMB1) block. Cesar
