On Fri, Jun 21, 2013 at 1:26 PM, Kirill Yukhin <kirill.yuk...@gmail.com> wrote:
> Hi,
> As mentioned be Jakub, Intel Spec introduces single-underscored
> intrinsics for bextr insn which takes different arguments.
>
> Patch introduces intrinsics and tests.
> ChangeLog:
> 2013-06-20  Kirill Yukhin
> <kirill.yuk...@intel.com>
>

Hm, your mailer is mangling lines.

>
>         * config/i386/i386-builtin-types.def:
> Define

Dot here.

Why do you need to change
>
>         UINT64_FTYPE_UINT64_UINT64_UINT64 and
> UINT_FTYPE_UINT_UINT_UINT.
>
>         * config/i386/i386.c (IX86_BUILTIN_BEXTR32_3ARGS):
> New.
>
>         (IX86_BUILTIN_BEXTR64_3ARGS):
> Ditto.
>
>         (bdesc_args): New builtins
> definition.
>
>         (ix86_expand_args_builtin): Expand new ftypes.
>
> testsuite/ChangeLog:
> 2013-06-20  Kirill Yukhin
> <kirill.yuk...@intel.com>
>
>
>
>         * gcc.target/i386/bmi-1.c: Extend with new
> instrinsic.
>
>         Fix scan
> patterns.
>
>         * gcc.target/i386/bmi-1.c:
> Ditto.
>
>         * gcc.target/i386/bmi-bextr-3.c:
> New.
>
>         * gcc.target/i386/bmi-bextr-4.c:
> Ditto.
>
>
> Is it ok to install?

This is OK for mainline.

BTW: There are many other single-underscore prefixed intrinsics [1]
besides _bextr_*. Perhaps you should also add these to the intrinsics
header, then the complete header could be backported to other release
branches.

[1] 
http://software.intel.com/sites/products/documentation/studio/composer/en-us/2011Update/compiler_c/intref_cls/common/intref_bk_avx2_manipulate.htm

Uros.

Reply via email to