On Wed, Jul 31, 2013 at 6:44 AM, Tim Shen <timshe...@gmail.com> wrote: > On Wed, Jul 31, 2013 at 6:10 AM, Paolo Carlini <paolo.carl...@oracle.com> > wrote: >> I reverted the commit and tested that mainline is fine again. > > Sorry for the accident! > >> Just to clarify how we normally handle these issues in v3: *temporarily*, to >> avoid the linkage issues which broke the bootstrap today, all the >> non-template functions must be inline, even if large. In the past normally >> we had the definitions of such functions in *.tcc files, thus explicitly >> inline, with FIXME comments. I think it makes sense to do this for regex >> too. In any case, as soon as the design stabilizes all such functions shall >> be exported by the dynamic library, thus in practice all the definitions >> will be moved to src/c++11/*.cc files. > > I see. > > > So I include <regex> in different files and then compile them > together, it broke. I've make every non-templated function in this > commit inline. Now it compiles. > > Sorry again for this commit. > > Should I commit again? > > > -- > Tim Shen
-- Tim Shen
inline.patch
Description: Binary data
