I have made all the requested changes. I am in the process of
bootstrapping and running the regressions one last time. Assuming the
bootstrapping & regression tests pass, is this ok to commit?
-- Caroline
cmt...@google.com
On Tue, Aug 6, 2013 at 2:45 PM, Diego Novillo <dnovi...@google.com> wrote:
> On Tue, Aug 6, 2013 at 2:39 PM, Benjamin De Kosnik <b...@redhat.com> wrote:
>>
>>> > +# Filter out unsupported systems.
>>> > +case "${target}" in
>>> > + x86_64-*-linux* | i?86-*-linux*)
>>> > + VTV_SUPPORTED=yes
>>> > + ;;
>>> > + powerpc*-*-linux*)
>>> > + ;;
>>> > + sparc*-*-linux*)
>>> > + ;;
>>> > + arm*-*-linux*)
>>> > + ;;
>>>
>>> What about powerpc, sparc and arm? Why are they mentioned here if no
>>> actual decision is made about support?
>>
>> This is more a practical consideration: it's the middle of summer
>> break. Let's error on the side of caution for the moment, and get
>> this in causing minimal disruption on a convenient platform that I can
>> verify myself easily.
>>
>> On a practical note, the libsanitizer acceptance
>> criteria was/is as above, seems sensible to do the same thing with
>> libvtv.
>>
>> Once this is in trunk, let a million flowers bloom! There is no
>> reason specific platform/target maintainers can't enable it at their
>> leisure on a per-setup manner and when they can verify testresults
>> easily.
>
> Agreed. The comments I had have been already addressed by Caroline,
> AFAICT. Once she has that, the patch can go in.
>
>
> Diego.
