Ok. Will drop it in the next patch. David
On Wed, Aug 14, 2013 at 11:23 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Wed, Aug 14, 2013 at 08:17:55PM +0200, Marek Polacek wrote: >> On Wed, Aug 14, 2013 at 11:12:27AM -0700, Xinliang David Li wrote: >> > Index: ChangeLog >> > =================================================================== >> > --- ChangeLog (revision 201732) >> > +++ ChangeLog (working copy) >> > @@ -1,4 +1,8 @@ >> > 2013-08-14 Xinliang David Li <davi...@google.com> >> > + * config/i386/i386.c (ix86_option_override_internal): >> > + Fix potential unitialized variable error. >> >> The CL entry is missing a blank line. > > Also, the patch is not obvious. The uninitialization is not potential, it > is unconditional for n == 0, but more importantly, nothing ever uses > input_ranges[...].min field, so it is clearly a write only field and thus > IMHO should be dropped altogether together with the mins variable. > > Jakub
