Do you need to guard the jump function access with check if (ipa_node_params_vector.exists ())?
Ideally, useful_cold_callee should be folded into the inline hints estimation. Question about the heuristic: why filtering out PASS_THROUGH parameter cases completely? Passing 'this' parameter in many cases can result in good PRE opportunities. Why not skip the unknown type? David On Tue, Aug 20, 2013 at 12:26 PM, Easwaran Raman <era...@google.com> wrote: > The current hot caller heuristic simply promotes edges whose caller is > hot. This patch does the following: > * Turn it off for applications with large footprint since the size > increase hurts them > * Be more selective by considering arguments to callee when the > heuristic is enabled. > > This performs well on internal benchmarks. Ok for google/4_8 branch if > all tests pass? > > - Easwaran
