On Fri, Nov 01, 2013 at 04:13:05PM -0700, Konstantin Serebryany wrote:
> 2013-10-XX Kostya Serebryany <[email protected]>
It is November now ;)
Looks good to me, except for a few ChangeLog issues:
> Update to match the changed asan API.
> * asan.c:
> (asan_function_start): New function.
Wrong ChangeLog formatting. The above should be:
* asan.c (asan_function_start): New function.
> (asan_emit_stack_protection): Update the string stored in the
> stack red zone to match new API. Store the PC of the current
> function in the red zone.
> (asan_global_struct): Update the __asan_global definition to match
> the new API.
> (asan_add_global): Ditto.
> * asan.h: Declare asan_function_start.
This should be:
* asan.h (asan_function_start): New prototype.
> * final.c:
> (final_start_function): Call asan_function_start.
Again, remove the first :, newline and whitespace (except for one space).
> * sanitizer.def: Rename __asan_init_v1 to __asan_init_v3.
* sanitizer.def (BUILT_IN_ASAN_INIT): Rename from __asan_init_v1
to __asan_init_v3.
>
> =========== libsanitizer/ChangeLog
>
> 2013-10-XX Kostya Serebryany <[email protected]>
>
> * All source files: Merge from upstream r191666.
> * merge.sh: Added lsan.
> * configure.ac: Added lsan.
* configure.ac (AC_CONFIG_FILES): Added lsan.
> * Makefile.am: Added lsan.
* Makefile.am (SUBDIRS): Add lsan.
> * sanitizer_common/Makefile.am: Added lsan.
That is not what you've changed. You've changed
* sanitizer_common/Makefile.am (sanitizer_common_files):
and changed formatting and added a few files, but nothing related to lsan.
> * asan/Makefile.am: Added dependency on lsan.
Again, list what you've changed there and describe the changes.
> * lsan/Makefile.am: New file.
> * asan/Makefile.in: Regenerate.
> * lsan/Makefile.in: Regenerate.
> * Makefile.in: Regenerate.
> * configure: Regenerate.
> * sanitizer_common/Makefile.in: Regenerate.
Ok with those changes.
Jakub
