On Tue, 2013-11-05 at 13:33 -0800, Mike Stump wrote:
> On Nov 5, 2013, at 12:44 PM, Oleg Endo <[email protected]> wrote:
> > +/* { dg-do compile { target "sh*-*-*" } } */
>
> Why do this, when sh-torture.exp does this:
>
> if { ![istarget sh*-*-*] } then {
> return
> }
>
> ? I suspect you merely copied the style from the other test cases.
Exactly.
> If there isn't a good reason to do this, please don't.
>
You're right, it's redundant. It should be just
/* { dg-do compile } */
shouldn't it?
I can change that before committing, no problem.
I can also fix the other existing SH tests to prevent further copy pasta
as a separate patch.
Cheers,
Oleg
