On Sun, Nov 10, 2013 at 1:08 PM, Eric Botcazou wrote:
>> > +
>> > + profile_status_for_function (fn)
>> > + = (flag_guess_branch_prob ? PROFILE_GUESSED : PROFILE_ABSENT);
>> > + node->frequency
>> > + = hot ? NODE_FREQUENCY_HOT : NODE_FREQUENCY_NORMAL;
>>
>> In GCC code style the = goes at the end of the line:
>>
>> profile_status_for_function (fn)
>> (flag_guess_branch_prob ? PROFILE_GUESSED : PROFILE_ABSENT);
>> node->frequency =
>> hot ? NODE_FREQUENCY_HOT : NODE_FREQUENCY_NORMAL;
>
> Absolutely not, Teresa's version is the correct one, see reload.c for example.
Hmm, "absolutely"?
[stevenb@gcc1-power7 trunk]$ egrep -ch "^\s+= " gcc/*.[ch] | awk
'{sum=sum+$1}END{print sum}'
1797
[stevenb@gcc1-power7 trunk]$ egrep -ch "\s=$" gcc/*.[ch] | awk
'{sum=sum+$1}END{print sum}'
685
I can't find a rule/guide in the GNU or GCC coding style documents.
Anyway, not important. The "=" starting a new line is the majority, so
Theresa please forget about my comment :-)
Ciao!
Steven
