On 19/11/13 16:48, Kyrill Tkachov wrote: > Hi all, > > This patch improves the rtx costs computation for the add/sub + shift > operations > for modes narrower than SImode. There's a bit of refactoring going on, but > essentially they are computed in the same way that SImode costs for these > operations are computed, except that only left-shifts are considered for the > narrow ones. > > Regtested arm-non-eabi on qemu and bootstrapped on a Chromebook before trunk > for > arm became unstable recently. > > Ok for trunk? > > Thanks, > Kyrill > > 2013-11-19 Kyrylo Tkachov <kyrylo.tkac...@arm.com> > > * config/arm/arm.c (arm_new_rtx_costs): > Handle narrow mode add-shifts properly. > * config/arm/arm-common.c (arm_rtx_shift_left_p): Remove static. > * config/arm/arm-common-protos.h (arm_rtx_shift_left_p): > Declare extern. > >
Please move the ifdef/undef outside of the function definition. OK with that change. R.
