On Wed, Dec 04, 2013 at 06:09:56PM +0400, Konstantin Serebryany wrote:
> This is a maintenance problem because we can not test if we broke
> something during development.
> e.g. clang doesn't seem to support -fno-dwarf2-cfi-asm
It does, at least both clang 3.3 (from Fedora 19) and clang
3.4 r194685 (which I've built myself some time ago just to look at the
use-after-return etc. sanitization).
> I can commit a change similar to your cfi-related changes
> (guarded by SANITIZER_DONT_USE_CFI_ASM instead of
> __GCC_HAVE_DWARF2_CFI_ASM), but the problem will arise again
Why? Is it so hard to remember that when you add .cfi_* directives
they should be guarded by that macro? Even if the patch author
forgets about that, patch reviewer should catch that.
Jakub
