Ok for google branch. It might be good to think about adding regression tests (similar to those gcov tests under g++.dg/gcov, but handling multiple files).
David On Fri, Jan 17, 2014 at 12:59 PM, Rong Xu <x...@google.com> wrote: > last attachment is not the complete patch. Re-send again. > > On Fri, Jan 17, 2014 at 12:51 PM, Rong Xu <x...@google.com> wrote: >> Do we have to split params.def? >> >> I can include params.h and link in params.o (a special version as we >> don't have some global vars). >> >> As for lipo_cutoff, I think we don't need a special handling -- we >> should use the default value of 100 and let logic in dyn-ipa.c takes >> care of the rest. >> >> Please find the update patch which reads the default values from params.def. >> >> -Rong >> >> On Fri, Jan 17, 2014 at 12:05 PM, Xinliang David Li <davi...@google.com> >> wrote: >>> For LIPO parameters, you can do this >>> 1) isolate all LIPO specific parameters into lipo_params.def, and >>> include it from params.def. >>> 2) include lipo_params.def (after proper definition of DEFPARAM) in >>> the profile tool source dir. >>> >>> By so doing, the compiler setting and profile tool will be in sync. >>> (Unfortuately, for historic reason, the lipo_cutoff default val is >>> still set in dyn-ipa.c even with the parameter, so some comments needs >>> to be added in dyn-ipa.c to make sure the value should be doubly >>> updated). >>> >>> David >>> >>> On Fri, Jan 17, 2014 at 11:15 AM, Rong Xu <x...@google.com> wrote: >>>> Hi, >>>> >>>> This patch port the gcov-tool work to google/gcc-4_8 branches. >>>> >>>> Tested with spec2006, profiledbootstrap and google internal benchmarks. >>>> >>>> -Rong
