Jakub Jelinek <ja...@redhat.com> writes: > On Sat, Jan 18, 2014 at 10:37:18AM +0000, Richard Sandiford wrote: >> Review ping for this patch. IMO it almost counts as obviously correct >> but just in case... >> >> Kito Cheng <k...@0xlab.org> writes: >> > expand_movstr is work fine when we don't define movstr pattern or >> > always expand it successfully, however it's will crash when if movstr >> > expand fail since expand_insn expect always expand successfully (it's >> > place a gcc_unreachable() when expand fail). >> > >> > this patch use maybe_expand_insn instead of expand_insn, check it done >> > or not and just return NULL_RTX for generate a libcall if fail to >> > expand movstr. >> > >> > 2014-01-11 Kito Cheng <k...@0xlab.org> >> > >> > * gcc/builtins.c (expand_movstr): Check movstr expand done or fail. > > Ok.
Thanks. It doesn't look like Kito has commit access so I went ahead and applied it. Kito, thanks for the patch. Richard