On Fri, 31 Jan 2014, Andrew Pinski wrote: > On Fri, Jan 31, 2014 at 5:59 AM, H.J. Lu <hongjiu...@intel.com> wrote: > > Hi, > > > > For 64-bit Android, long double is 128-bit IEEE-754 floating point type. > > This patch adds -mlong-double-128 to i386 and makes it default for 64-bit > > Bionic. I only added MASK_LONG_DOUBLE_128. I made -mlong-double-128, > > -mlong-double-64 and -mlong-double-80 negate each other so that the > > last one on command line wins. It os OK since we don't support > > -mlong-double-xxx in target attribute. I added some testcases to verify > > it works correctly. OK for trunk? > > I don't see any where in the documentation that explains the > difference between -mlong-double-128 and -m128bit-long-double. Can > you please add that -mlong-double-128 causes soft-floating point. > Also what about the interactions between these two options.
Yes, I think the invoke.texi documentation for each of these options needs to cross-reference the other one of the options and explain the difference explicitly. I would add: to confirm, does __float80 remain available on 64-bit Android and provide access to XFmode there? (If not, the documentation of __float80 needs updating.) If in future we implement TS 18661-3 in GCC, it will be necessary to work out in cases such as this whether _Float64x should have the representation of __float80 or __float128 (I'd guess __float80 would be better). -- Joseph S. Myers jos...@codesourcery.com
