> On Wed, 5 Feb 2014, Jakub Jelinek wrote:
> 
> > Hi!
> > 
> > Using !!optimize to determine if we should switch local ABI to regparm
> > convention isn't compatible with optimize attribute, as !!optimize is
> > whether the current function is being optimized, but for the ABI decisions
> > we actually need the caller and callee to agree on the calling convention.
> > 
> > Fixed by looking at callee's optimize settings all the time.
> > 
> > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> 
> Seeing a 2nd variant of such code I'd rather have an abstraction
> for this ... optimize_fn ()?  opt_for_fn (fn, OPT_...)?

Propbable opt_for_fn.  I wanted to implement SSE passing conventions for local
functions but didn't get to it since I was concerned about -fno-sse being
passed to teh callee by target attribute.  Having API to check those would be 
nice.

Honza

Reply via email to