On 02/12/14 12:34, James Greenhalgh wrote:
Hi,
This patch fixes a nuisance with the comments in the cost tables.
Presently they are in sentence case, which to any casual observer
(i.e. me) would suggest that the field name should begin with
an upper-case character, .Fma for example. Also irritating is trying
to find the cost of the real .fma, which a case-sensitive grep won't
spot. GNU style explicitly calls this sort of mangling of identifiers
out as bad practice.
I've checked that both AArch64 and ARM toolchains still build after
this minor change.
OK for trunk/stage-1 (I don't mind which)?
I'd prefer to take this now as it is effectively only a fix for comments
and the patch only affects comments. Let's finish the churn for 4.9.
Ok by me but I'd like the RM ack.
Ramana
Thanks,
James
---
gcc/
2014-02-12 James Greenhalgh <james.greenha...@arm.com>
* config/arm/aarch-cost-tables
(generic_extra_costs): Fix identifiers in comments.
(cortexa53_extra_costs): Likewise.
* config/arm/arm.c
(cortexa9_extra_costs): Fix identifiers in comments.
(cortexa7_extra_costs): Likewise.
(cortexa12_extra_costs): Likewise.
(cortexa15_extra_costs): Likewise.
(v7m_extra_costs): Likewise.
--
Ramana Radhakrishnan
Principal Engineer
ARM Ltd.
