Kai Tietz <[email protected]> writes:
> 2014-03-17 21:50 GMT+01:00 Rainer Orth <[email protected]>:
>> Hi Kai,
>>
>>> this patch fixes some regressions introduced by default-option
>>> -fms-extensions for mingw-targets.
>>
>> you should state in your submissions *which* regressions were
>> introduced/*which* problem you are fixing. While this may be obvious to
>> you, it's often not so to reviewers.
>
> I did. "The regressions in testsuite are introduced by turning on the
> state of -fms-extensions." That all, and not more to tell.
You didn't. *Which* regressions? What happens? I had to infer it from
a comment in one of the changed testcases:
/* In strict ISO C mode, we don't recognize the anonymous struct/union
extension or any Microsoft extensions. */
If you'd cited the compiler error you get for one of the testcases,
everything had been clear.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
