On Wed, 2014-03-19 at 12:10 -0600, Tom Tromey wrote: > >>>>> "Tom" == Tom Tromey <tro...@redhat.com> writes: > > Tom> This patch introduces a new "class toplev" and changes toplev_main and > Tom> toplev_finalize to be methods of this class. Additionally, now the > Tom> timevars are automatically stopped when the object is destroyed. This > Tom> cleans up "compile" a bit and makes it simpler to reuse the toplev > Tom> logic in other code. > > David asked me off-list to rename the field in class toplev, so here's a > new patch that does this.
Thanks! (yes, I greatly prefer having member data of a class to have a "m_" prefix, and for the ctor params to have equivalent names, without the prefix, which this patch does, for "toplev"). > Tom > > commit 66f92863ef55c26f673d02dd39027f340940a3bf > Author: Tom Tromey <tro...@redhat.com> > Date: Tue Mar 18 08:07:40 2014 -0600 > > introduce class toplev > > This patch introduces a new "class toplev" and changes toplev_main and > toplev_finalize to be methods of this class. Additionally, now the > timevars are automatically stopped when the object is destroyed. This > cleans up "compile" a bit and makes it simpler to reuse the toplev > logic in other code. OK. Are you able to push this to my branch, or do you need me to do this?
