On 19/03/14 21:39 +0000, Jonathan Wakely wrote:
I think the safe thing to do is (as I suggested at the time) to have a trait saying which iterator types refer to contiguous memory. Our debug mode only supports our own containers, so the ones which are contiguous are known. For 4.9.0 I think the right option is simply to remove __foreign_iterator_aux3 and __foreign_iterator_aux4 completely. The fixed version of __foreign_iterator_aux2() can detect when we have iterators referring to the same sequence, which is what we really want to detect. That's what the attached patch does and what I'm going to test.
With my suggested change we get an XPASS for testsuite/23_containers/vector/debug/57779_neg.cc An __is_contiguous trait would solve that.
