Hi Andi, I'll work on putting together some good documentation before sending this and follow-on support to trunk. As David mentions, the plan for the subsequent patch to add the hooks that enable users to trigger gcc's value profiling on particular variables. This first patch simply allows users to define their own profiling routines, that automatically only get compiled in on the profile-gen build and have the results automatically applied to the profile-use compile via the gcda file.
Thanks, Teresa On Sat, May 10, 2014 at 3:44 PM, Xinliang David Li <davi...@google.com> wrote: > User directed value profiling will also be supported but not in this patch. > > David > > On May 10, 2014 2:59 PM, "Andi Kleen" <a...@firstfloor.org> wrote: >> >> On Fri, May 09, 2014 at 08:11:40PM -0700, Teresa Johnson wrote: >> > Thanks for catching that, I will fix it. >> >> BTW I first misunderstood the goal of you patch. >> >> (probably because there is no documentation ... something that should >> also be fixed) >> >> I originally thought it was a way to let user code use the value profiling >> libgcov functions to profile arbitary values, and then later use the >> most common value for some optimization. >> >> But instead it seems to be only an (somewhat over complicated) IO >> mechanism to let user programs write arbitrary values to the gcov file and >> pass it back. >> >> I think I would find the first more useful. >> >> -Andi >> > -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
