On Tue, 2014-05-27 at 17:12 +0100, Richard Sandiford wrote: > "Steve Ellcey " <sell...@mips.com> writes: > > The recent comdat group changes broke the mips build because mips.c > > was not including cgraph.h. I am checking in the following patch > > as obvious to fix the mips build. > > Wasn't that fixed by: > > 2014-05-26 Jan Hubicka <hubi...@ucw.cz> > > * tree.h (decl_comdat_group): Declare. > * cgraph.h (symtab_in_same_comdat_p): Move offline to ... > * tree.c (decl_comdat_group): Here. > > ? > > Thanks, > Richard
It didn't fix the build for me. I still got this failure after that patch: /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c: In function 'void mips_start_unique_function(const char*)': /local/home/sellcey/nightly/src/gcc/gcc/config/mips/mips.c:6278:27: error: 'cgraph_create_node' was not declared in this scope make[2]: *** [mips.o] Error 1 When I grepped for cgraph_create_node I found it in cgraph.h. Steve Ellcey sell...@mips.com