> Note that I'm happy to revert the change. Thanks.
> I am hesitant to any approach that overloads TREE_ADDRESSABLE even more. > It already is used for two (slightly) different things - first the > "old" meaning that the address of the symbol is needed, second, that > the symbol is aliased by pointers. Those are of course related, but > as you see they are not 100% equivalent. > > As I already added DECL_NONALIASED (for VAR_DECLs) to "fix" that > coverage counter issue (those are TREE_STATIC but they have their > address taken - still we know that no pointers alias the accesses), > we can as well rely on that flag - but then we should set it whenever > a TU-local decl does not have its address taken (!TREE_ADDRESSABLE). Why not just make the change to may_be_aliased in LTO mode, with a comment saying that TREE_PUBLIC and DECL_EXTERNAL aren't fully correct any longer? -- Eric Botcazou
