Re: [PATCH, PR 61540] Do not ICE on impossible devirtualization

[Bernhard Reutner-Fischer]

On 18 June 2014 10:24:16 Martin Jambor <mjam...@suse.cz> wrote:
@@ -3002,10 +3014,8 @@ try_make_edge_direct_virtual_call (struct 
cgraph_edge *ie,

   if (target)
     {
-#ifdef ENABLE_CHECKING
-      gcc_assert (possible_polymorphic_call_target_p
-        (ie, cgraph_get_node (target)));
-#endif
+      if (!possible_polymorphic_call_target_p (ie, cgraph_get_node (target)))
+       return ipa_make_edge_direct_to_target (ie, target);
       return ipa_make_edge_direct_to_target (ie, target);
     }

The above looks odd. You return the same thing both conditionally and 
unconditionally?

Thanks,
   else



Sent with AquaMail for Android
http://www.aqua-mail.com