Hi Martin, >> >> Well actually, I am not sure if we ever wanted to have a race condition here. >> Have you seen any impact of --param allow-store-data-races on any benchmark? > > It's trivially to write one. The only pass that checks the param is > tree loop invariant motion and it does that when it applies store-motion. > Register pressure increase is increased by a factor of two. > > So I'd agree that we might want to disable this again for -Ofast. > > As nothing tests for the PACKED variants nor for the LOAD variant > I'd rather remove those. Claiming we don't create races for those > when you disable it via the param is simply not true. > > Thanks, > Richard. >
OK, please go ahead with your patch. Thanks Bernd.