> On June 23, 2014 6:15:10 PM CEST, Jan Hubicka <hubi...@ucw.cz> wrote: > >> I don't like this very much. It's fragile and it will be very hard > >to > >> detect bugs caused by it. > >> > >> Please don't spread uses of the DECL_NONALIASED "hack". > >> > >> If we are only concerned about LTO I'd rather have a in_lto_p check > >> in may_be_aliased and trust TREE_ADDRESSABLE there. > > > >I do not like it ether, but I tought it was outcome of the discussion > >to use > >it. > > > >I do not see how in_lto_p helps here, but we probably want to go for > >the > > If we are sure it is correctly set in lto1 it helps. > > >altnerative where ipa-visibility sets TREE_ADDRESSABLE for all external > >variables and then we trust it unconditonally? > > That works for me, too. But at least add a checking assert that > may-be-aliased is not invoked before that.
OK, I suppose can check cgraph_state for that (after construction it will be all set). Will prepapre patch tonight. Honza > > Richard. > > > > > >Honza >
