On June 24, 2014 9:16:34 PM CEST, Trevor Saunders <tsaund...@mozilla.com> wrote: >On Tue, Jun 24, 2014 at 08:23:49PM +0200, Jan Hubicka wrote: >> > >> > On 06/20/2014 12:52 PM, tsaund...@mozilla.com wrote: >> > >From: Trevor Saunders <tsaund...@mozilla.com> >> > > >> > >Hi, >> > > >> > >This patch adds a hash_map class so we can consolidate the boiler >plate around >> > >using hash_table as a map, it also allows us to get rid of >pointer_map which I >> > >do in this patch by converting its users to hash_map. >> > >> > Hello Trev, >> > I like your changes! One small question about pointer_set, which >is unable of deletion of items. Do you plan to migrate and simplify >hash_map to be a replacement for pointer_set? >> >> Note that pointer-map use in LTO is quite performance critical. It >would be good to double >> check that the new use of hash does not produce slower code. > >I believe the compiled code should be very similar, but I'll do some >measuring to check.
More important is memory use. Richard. >Trev > >> >> Honza
