> For formatting, can you please just replace 8 spaces with tabs > in the ^+ lines in the patch?
Sorry, I thought I cleared all these out but looks like I indeed missed some whites. I should probably take some time and finally setup my editor to do this. > Can you avoid using // comments in code that uses /* */ comments? Thanks, this TODO should have been included in the patch to begin with. > If all the ifns have a bitmask argument, one question is if we really > want ASAN_LOAD vs. ASAN_STORE, instead of a single ASAN_CHECK that > would actually have ASAN_CHECK_IS_STORE as one of the flags. True. >> + gcc_assert (seq); > > Uh. Can you please explain this? That sounds weird. Sure, this caused maybe-uninitialized warnings with iterator during bootstrap. It turned out that *bb_seq_addr (bb) in gsi_start (bb) returned something like bb.flags & GIMPLE ? bb.il.gimple.seq : NULL and when GCC saw *NULL it rushed to generated uninitialized read. This assert silences compiler. -Y
