On Wed, Jul 23, 2014 at 5:40 AM, Jeff Law <l...@redhat.com> wrote: > On 07/15/14 23:31, Andi Kleen wrote: >> >> From: Andi Kleen <a...@linux.intel.com> >> >> No substantial changes, although the hash values will be slightly >> different. >> >> gcc/: >> >> 2014-07-10 Andi Kleen <a...@linux.intel.com> >> >> * lto-streamer-out.c (hash_tree): Convert to inchash. >> (add_flag): New macro. > > So my question here, does this make any existing LTO objects no longer > usable? If so, what, if any policy do we have when we make that kind of > change? > > If existing LTO objects continue to work, then this patch is fine too once > the explicit begin/end vs ctor/dtor stuff is fixed.
I'd say add_flag should be in the hash abstraction? You convert only some to hash_flag and not all of them - why? For example I don't like your handling of TYPE/DECL_MODE. Please refrain from doing semantical changes like that and call it a simple refactoring. Richard. > > jeff > >