On 09/02/2014 08:34 AM, Kyrill Tkachov wrote: > 2014-09-02 Kyrylo Tkachov <kyrylo.tkac...@arm.com> > > * config/aarch64/predicates.md (aarch64_comparison_operation): > New special predicate. > * config/aarch64/aarch64.md (*csinc2<mode>_insn): Use > aarch64_comparison_operation instead of matching an operator. > Update operand numbers. > (csinc3<mode>_insn): Likewise. > (*csinv3<mode>_insn): Likewise. > (*csneg3<mode>_insn): Likewise. > (ffs<mode>2): Update gen_csinc3<mode>_insn callsite. > * config/aarch64/aarch64.c (aarch64_get_condition_code): Export. > Return -1 instead of aborting on invalid condition codes. > (aarch64_print_operand): Update aarch64_get_condition_code callsites > to assert that the returned condition code is valid.
Looks good to me. Note that you missed the ChangeLog entry for aarch64-protos.h. r~
